Fix trailing return type in virtual functions#55644
Closed
j-piasecki wants to merge 3 commits intofacebook:mainfrom
Closed
Fix trailing return type in virtual functions#55644j-piasecki wants to merge 3 commits intofacebook:mainfrom
j-piasecki wants to merge 3 commits intofacebook:mainfrom
Conversation
meta-cla
bot
added
the
CLA Signed
facebook-github-bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D93407597. |
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Feb 20, 2026
Summary: Pull Request resolved: facebook#55644 Changelog: [Internal] Updates the C++ api snapshot generator to correctly handle trailing return types for pure virtual functions. Differential Revision: D93407597
j-piasecki
force-pushed
the
export-D93407597
branch
from
a32a619 to
2525258
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Feb 23, 2026
Summary: Pull Request resolved: facebook#55644 Changelog: [Internal] Updates the C++ api snapshot generator to correctly handle trailing return types for pure virtual functions. Reviewed By: cipolleschi Differential Revision: D93407597
j-piasecki
force-pushed
the
export-D93407597
branch
from
2525258 to
ce7cd08
Compare
added 2 commits
February 25, 2026 05:43
Summary: Refactors utils.py into a proper package structure and adds comprehensive argument string parsing utilities. - Converts utils.py to utils/ package with submodules - Adds argument_parsing.py with parse_arg_string() and related utilities - Adds qualified_path.py with parse_qualified_path moved from old utils.py - Renames test_member.py to test_parse_arg_string.py with updated tests for the new 4-tuple Argument format - Minor cosmetic improvement to doxygen output messages Differential Revision: D94077819
Summary: Implements fallback name qualification for cases where doxygen doesn't extract the full qualified name, and instead passes on the string it found in the header file. - Adds type_qualification.py with qualify_type_str(), qualify_arguments(), and qualify_parsed_type() - Updates member.py with close() methods for VariableMember, FunctionMember, and TypedefMember to apply type qualification - Updates main.py with get_doxygen_params() to extract structured parameter info - Fixes scope.py qualify_name() to properly track anchor_scope for partially-qualified names - Adds comprehensive test cases for various qualification scenarios Differential Revision: D94077825
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Feb 25, 2026
Summary: Pull Request resolved: facebook#55644 Changelog: [Internal] Updates the C++ api snapshot generator to correctly handle trailing return types for pure virtual functions. Reviewed By: cipolleschi Differential Revision: D93407597
j-piasecki
force-pushed
the
export-D93407597
branch
from
ce7cd08 to
7e3947a
Compare
Summary: Pull Request resolved: facebook#55644 Changelog: [Internal] Updates the C++ api snapshot generator to correctly handle trailing return types for pure virtual functions. Reviewed By: cipolleschi Differential Revision: D93407597
j-piasecki
force-pushed
the
export-D93407597
branch
from
7e3947a to
b7f81c8
Compare
|
This pull request has been merged in bf4978e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Updates the C++ api snapshot generator to correctly handle trailing return types for pure virtual functions.
Differential Revision: D93407597